Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techdebt/1 block file retrieval test #51

Merged
merged 6 commits into from
Jan 22, 2020

Conversation

shannonwells
Copy link
Contributor

@shannonwells shannonwells commented Jan 21, 2020

Add a test to ensure that a file that will be retrieved with only 1 block transfer succeeds (it failed previously). Test includes using a provider subscriber that receives a notification when the deal is complete.

@shannonwells shannonwells changed the title Techdebt/1 block file retrieval test [WIP] Techdebt/1 block file retrieval test Jan 21, 2020
@shannonwells shannonwells force-pushed the techdebt/1-block-file-retrieval-test branch from c624dbc to e357ee3 Compare January 22, 2020 01:15
@shannonwells shannonwells changed the title [WIP] Techdebt/1 block file retrieval test Techdebt/1 block file retrieval test Jan 22, 2020
@codecov-io
Copy link

Codecov Report

Merging #51 into master will increase coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   29.59%   29.98%   +0.39%     
==========================================
  Files          33       33              
  Lines        2349     2349              
==========================================
+ Hits          695      704       +9     
+ Misses       1577     1569       -8     
+ Partials       77       76       -1
Impacted Files Coverage Δ
...ievalmarket/impl/providerstates/provider_states.go 94.32% <ø> (ø) ⬆️
retrievalmarket/impl/clientstates/client_states.go 99.02% <100%> (ø) ⬆️
retrievalmarket/impl/provider.go 71.56% <0%> (+7.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0321c8c...1e8aae8. Read the comment docs.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit db66f33 into master Jan 22, 2020
@shannonwells shannonwells deleted the techdebt/1-block-file-retrieval-test branch January 22, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants